Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Italian #886

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add support for Italian #886

merged 2 commits into from
Mar 4, 2024

Conversation

nicolello-dev
Copy link
Contributor

I chose "scheda" as the translation for card. "Carta" is also a valid option, although "scheda" has a nuance of information, while "carta" is more like a card for gaming, hence why I chose the former

I chose "scheda" as the translation for card. "Carta" is also a valid option, although "scheda" has a nuance of information, while "carta" is more like a card for gaming, hence why I chose the former
Copy link
Collaborator

@ronzulu ronzulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nicola!

There is a formatting issue automatically detected by the "lint" tool (typically something very minor, e.g. extra blank line), see:
https://github.com/st3v3nmw/obsidian-spaced-repetition/actions/runs/8039886954/job/22221024041?pr=886

[warn] src/lang/locale/it.ts
[warn] Code style issues found in the above file. Run Prettier to fix.

Some info is available at:
https://www.stephenmwangi.com/obsidian-spaced-repetition/contributing/#code

It's listed under the "code" heading, but the following applies to all .ts files:

Before pushing your changes, run the linter: pnpm lint
Format the code in case any warnings are raised: pnpm format

@nicolello-dev
Copy link
Contributor Author

Thank you, didn't catch that :)

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@st3v3nmw st3v3nmw merged commit 6be077a into st3v3nmw:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants