Fix issue requiring collapseIcon to be clicked twice to expand/collapsed deck tree #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
The problem is that the initial value of
collapsedwas being set to theshouldBeInitiallyExpandedconfig value, even though these booleans should be opposite (collapsed vs. expanded).Because the initial UI was set from
shouldBeInitiallyExpanded, but the callback to the click event checkedcollapsed, the first click would make no visual change, but merely set thecollapsedvariable to be correct, and the second click would work as expected.Technically only the change on line
846is necessary, but the other two changes prevent the same visual confusion from occurring in the future by ensuring that that the UI andcollapsedare in sync.