refactor: parser & cloze patterns #1117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the parser to use
peggy
has slowed the plugin drastically (See #1115, #1111, & #1110). This change refactors the parser to one written by hand compared to an auto-generated one. I think this is the better approach for performance reasons & it's sad that we have to undo all the work that went into #1012.I've tried to replicate the existing behavior as closely as possible with the new parser including the multiline cards with spaces introduced in #1012.
On the brighter side, we've switched parsing of cloze cards to use @MotaOcimar's clozecraft package from #943.