-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] HTML review comment deactivates block identifier #815
Comments
For anyone looking to fix this... From experimenting, it seems that the block identifier must be right at the end of the line. If there is anything after the block identifier before the EOL, obsidian won't recognize it as the block identifier. I think this can be fixed without adding a new user setting. I can't think of a reason why someone would want the current formatting. The following shows where the OSR info should be placed: Format of block identifiers:
I.e. not just hex characters, e.g.:
Cheers |
I'll try and fix this over the next week. Unless someone else is busting to do it :-) |
Hi @sebthoms and anyone else reading... Beta release is now available. There is a file called You will need to copy that to the obsidian plug-in folder, e.g. Then reload the plug-in, or restart obsidian. Any feedback appreciated. Ronny |
It works perfectly now. Thanks a lot! |
… (#834) * First bit of implementation * Slight refactor of parse() * Enhanced parser to return first and last line numbers * Finished impl for enhanced parsing for multiple topics per note, updated existing test cases (haven't fixed main.js or added all needed test cases) * Implementation & testing continuing * Comment change * pnpm format; updated changelog.md * pnpm lint * Need to rerun lint after format, and rerun format after lint * Updated flashcard user documentation * Added code to access the frontmatter tags * Fixed test cases after merging with #815 * lint & format * Fixed unit test case * Minor * Minor post merge fix * Lint * Fixed test case --------- Co-authored-by: Stephen Mwangi <[email protected]>
Thanks a lot for creating this plugin, @st3v3nmw! It has been extremely useful for me.
There is just a small issue when creating flashcards from linked blocks.
Describe the bug
Whenever a HTML review comment is added to a flashcard containting a block identifier, the block identifier gets deactivated. This results in the other file being unable to locate that block.
becomes this:
(I should probably add that I configured ">>" to be my flashcard identifier)
Adding the HTML comment on a new line solves this, but this unfortunately breaks list formatting in other flashcards.
Any help is appreciated!
The text was updated successfully, but these errors were encountered: