Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PASSU 문제 해결 #444

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: PASSU 문제 해결 #444

wants to merge 4 commits into from

Conversation

jongse7
Copy link
Contributor

@jongse7 jongse7 commented Mar 6, 2025 •
edited
Loading

1️⃣ 작업 내용 Summary

PASSU 행사 도중 발견된 문제들에 대한 이슈를 해결했습니다.

  1. 누락된 영화예술전공 번역 추가
  2. 회원가입 이름 규칙 변경 (10자 -> 50자, 한글만 -> 영문 가능, 띄어쓰기가능)
  3. 특정 브라우저(삼성 인터넷)에서 SelectContent 컴포넌트가 잘리는 현상 해결(max-h 값 설정)

(author를 변경하면서 실수로 1a51fd2 커밋까지 포함이 됐습니다)

2️⃣ 추후 작업할 내용

3️⃣ 체크리스트

  • main 브랜치의 최신 코드를 pull 받았나요?

@jongse7 jongse7 added the fix label Mar 6, 2025
@jongse7 jongse7 self-assigned this Mar 6, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-homepage-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:28am

jongse7 added 3 commits March 6, 2025 12:11
@jongse7
feat: fileUrl에서 확장자명 추출 후 fileType 뒤에 삽입 #439 (#440)
1a51fd2 
- resolved #439

결과물 이미지

![image](https://github.com/user-attachments/assets/5a5e2ef0-f34e-49ed-931b-4db0b31b128a)

```
  **// fileUrl에서 확장자명을 추출한 후 대문자로 변경
  const lastDotIndex = file.fileUrl.lastIndexOf('.');
  const fileExtension = lastDotIndex !== -1 ? file.fileUrl.substring(lastDotIndex + 1) : '';**
  return (
    <a
      className={cn(
        buttonVariants(),
        'h-[31px] w-[143px] rounded-[9px] bg-gray-200 text-[16px] font-medium text-gray-600',
        'cursor-pointer overflow-hidden text-ellipsis whitespace-nowrap px-2 hover:text-white',
        className
      )}
      title={file.fileType}
      href={file.fileUrl}
      download={file.fileName}
    >
      **{`${file.fileType} ${fileExtension.toUpperCase()}`}**
    </a>
  );
```

확장자명 앞에만 .이 있는 게 아니라서 마지막 .을 기준으로 문자열 끝까지를 확장자명으로 추출했습니다.
디자인에는 확장자명을 대문자로 표현해서 toUpperCase()로 대문자화 했습니다.

더 좋은 방법 있으면 말씀해주세요 💀

- [x] `develop` 브랜치의 최신 코드를 `pull` 받았나요?
@jongse7
refactor: 이름 50자 제한, 영문 가능하게 변경 #441
02c2a15
@jongse7
fix: 삼성인터넷에서 SelectContent가 잘리는 현상 해결 #441
e44fc17
@jongse7 jongse7 force-pushed the fix/#441_passu_issue branch from 11e6588 to e44fc17 Compare March 6, 2025 03:11
@jongse7 jongse7 deployed to develop March 6, 2025 05:27 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EATSTEAK EATSTEAK EATSTEAK approved these changes

@nebulaBdj nebulaBdj Awaiting requested review from nebulaBdj

@naraeng naraeng Awaiting requested review from naraeng

@ssumai-kr ssumai-kr Awaiting requested review from ssumai-kr

At least 2 approving reviews are required to merge this pull request.

Assignees

@jongse7 jongse7

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jongse7 @EATSTEAK