fix: categoryName 필드 category 필드명으로 변경 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EATSTEAK
requested changes
Dec 10, 2024
jongse7
approved these changes
Dec 10, 2024
| @@ -190,7 +190,7 @@ export function PostPetitionDetailPostSection() { | |||
| </div> | |||
| </div> | |||
| <div className="xs:hidden sm:hidden md:hidden"> | |||
| <StateTag current={data?.data.postDetailResDto.categoryName || null} /> | |||
| <StateTag current={data?.data.postDetailResDto.category || null} /> | |||
dvp-tae
force-pushed
the
fix/#361_change-categoryName
branch
from
48a8cc3 to
a299143
Compare
parsedContent 를 GetBoardDetailResponse 타입으로 단언했는데 이렇게 해결하면 괜찮을까요? |
EATSTEAK
requested changes
Dec 10, 2024
src/pages/petition-notice/edit/containers/PetitionNoticeEditorSection.tsx
Outdated
Show resolved
Hide resolved
src/pages/petition-notice/edit/containers/PetitionNoticeEditorSection.tsx
Outdated
Show resolved
Hide resolved
src/pages/petition-notice/edit/containers/PetitionNoticeEditorSection.tsx
Outdated
Show resolved
Hide resolved
EATSTEAK
reviewed
Dec 10, 2024
src/pages/petition-notice/edit/containers/PetitionNoticeEditorSection.tsx
Outdated
Show resolved
Hide resolved
…Section.tsx Co-authored-by: Hyomin Koo <[email protected]>
…Section.tsx Co-authored-by: Hyomin Koo <[email protected]>
…Section.tsx Co-authored-by: Hyomin Koo <[email protected]>
…Section.tsx Co-authored-by: Hyomin Koo <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 작업 내용 Summary
기존 코드에 영향을 미치지 않는 변경사항
기존 코드에 영향을 미치는 변경사항
PostDetailResDto 타입 중 categoryName -> category 로 변경
PostPetitionDetailPostSection.tsx 타입 변경 적용
useAuditPatch.ts useLostPatch.ts usePartenership.ts 타입 변경 적용
버그 픽스
✚ 피그마
✚ 관련 문서
2️⃣ 리뷰어에게..
3️⃣ 추후 작업할 내용
4️⃣ 체크리스트
main브랜치의 최신 코드를pull받았나요?