Recover to link with libexpat and lib curl #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC_CHECK_LIB adds the -l<library> to LIBS and defines HAVE_<library> when the third argument is empty. This change recovers that behavior and now links with expat and curl correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize that #14 breaks the build: that never links with curl and expat.
This was due to my misunderstandings of the behavior of
AC_CHECK_LIB.AC_CHECK_LIB adds the -l to LIBS and defines HAVE_ when the
third argument is empty.
This change recovers that behavior and now links with expat and curl correctly.
Related