Do not force include and library dir in configure #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing the include and library path is not good when the user has a multiple prefix (e.g. /opt/local and /usr/local) for some reason. This situation is typical for macOS (MacPorts and Homebrew). By this change, user-specified ones are prefered over guessed prefixes. This behavior is more straightforward because the user can have the control of what header and library is to be linked.
|
I am sorry for bothering, @sshock but this is the final PR what I have in mind. Thanks 😄 |
|
No worries; I appreciate the patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing the include and library path is not good when the user
has a multiple prefix (e.g. /opt/local and /usr/local) for some reason.
This situation is typical for macOS (MacPorts and Homebrew).
By this change, user-specified ones are prefered over guessed prefixes.
This behavior is more straightforward because the user can have the control
of what header and library is to be linked.