-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFXTabPane no tab closing button #75
Comments
yeah , it's a known issue, it's planned to be implemented. |
I have same issue could you please tell me is this resolve or not? |
well this issue is not resolved yet in master branch, this issue is more of a design issue. Feel free to suggest any design for this issue and contribute to JFonenix. Regards, |
@jfoenixadmin, take a look on this plunkr example (not mine): It could be an idea, how to place the close button. Would be great, if we could have this feature soon! Edit; I made a workaround with a contextmenu (close, close all, close all but this) (does work for my desktop application, but may be wrong for mobile/web/touch applications) |
Bump @jfoenixadmin #241 solution is not that bad, it just needs some style improvements and change to JFXButton (minus cast reduction which is unnecessary) |
Well @skmedix, #241 is a good implementation (having a close policy) however the ui feels off. Maybe the 'X' button should be part of the tab content or should only appear when holding the tab title, Regards, |
Reading off of https://material.io/components/android/catalog/tab-layout/, the sentence "the Material Design guidelines for individual tabs is done in the tabs themselves" seems to suggest that the closing of the tab should be handled from within the individual tab content, and not the tab directly. An alternative would be a long-press on the tab to have a close button/menu appear, but that would be problematic if the tab size horizontally is small/limited. |
@jfoenixadmin Soon we will have an official solution. |
Cool, however I think they will simply add 'x' button right next to the tab title xD |
Hello, I pushed an updated for JFXTabPane to support CLOSE_ALL_TABS policy. Regards, |
As a temporarry solution ,You can add a ContextMenu to each tab like this example :
|
How to build this project? |
can u help me? pls sir, |
you can build JFoenix by running gradle build using the following command |
i have tried that ,but it didn't work |
will close this issue as JFXTabPane now supports CLOSE_ALL_TABS policy |
😄 👍 after long... time this issue was rise. it solved now... 👋 |
thnx |
Hello, |
What I really miss and I cant get it to work is a closing button on a Tab in the JFXTabPane.
Is this a known issue or is there a work around?
The text was updated successfully, but these errors were encountered: