Adding code for square wave oscillator and sawtooth oscillator.

[zackchase]

Added code for square wave oscillator, based on code for sin oscillator.

[ssfrr]

Hey Zach, just to summarize our email thread, this PR is mostly waiting on some tests and renaming SawtoothOsc to SawOsc. Also, at some point the default Saw and Square oscillators will be bandlimited so the behavior in this PR will be available with a bandlimit=false option. I can handle that part as part of merging it in.

[zackchase]

Hi Spencer, yes! I'll be on it soon. Just was traveling over the weekend in
Karnataka.

Z

On Sun, Aug 3, 2014 at 8:33 AM, Spencer Russell [email protected]
wrote:

Hey Zach, just to summarize our email thread, this PR is mostly waiting on
some tests and renaming SawtoothOsc to SawOsc. Also, at some point the
default Saw and Square oscillators will be bandlimited so the behavior in
this PR will be available with a bandlimit=false option. I can handle
that part as part of merging it in.

—
Reply to this email directly or view it on GitHub
#19 (comment).

[zackchase]

Hi Spencer - I just pushed the changes on my fork to incorporate the change
in nomenclature and add tests of SquareOsc and SawOsc. I believe the only
part of the tests that required any change were replacing the names
("SinOsc" with "SquareOsc" etc) and functions sin(phase) with the
appropriate functions.

On Tue, Aug 5, 2014 at 11:57 AM, zack [email protected] wrote:

Hi Spencer, yes! I'll be on it soon. Just was traveling over the weekend
in Karnataka.

Z

On Sun, Aug 3, 2014 at 8:33 AM, Spencer Russell [email protected]
wrote:

Hey Zach, just to summarize our email thread, this PR is mostly waiting
on some tests and renaming SawtoothOsc to SawOsc. Also, at some point the
default Saw and Square oscillators will be bandlimited so the behavior in
this PR will be available with a bandlimit=false option. I can handle
that part as part of merging it in.

—
Reply to this email directly or view it on GitHub
#19 (comment).

[ssfrr]

Hey Zach,

Thanks for adding the tests. Do they pass on your system? On mine I'm getting a couple failures with the SquareOsc and then it throws an error.

[ssfrr]

Little update - There were some issues with my travis config that were causing the travis tests to fail with all PRs. If you rebase on the latest master and re-push then travis should make it past the initial installation issues and then we'll be looking at the same test results.