-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add play/pause button to device #5
Conversation
8126d62
to
db77619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the npm audit step. With dependabot it is redundant.
@@ -33,8 +33,8 @@ | |||
}, | |||
"devDependencies": { | |||
"@playwright/test": "^1.45.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes in this file needed/expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, package-lock is generated by running npm install
it pins or "freezes" the dependency tree.
"@remix-run/dev": "^2.10.2", | ||
"@remix-run/testing": "^2.10.3", | ||
"@remix-run/dev": "^2.13.1", | ||
"@remix-run/testing": "^2.13.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right, right? Looks like you accidentally downgraded these packages maybe?
Whoops, sorry, I read this too quickly and totally missed the 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded npm upgrade
will upgrade packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have no idea what I'm looking at to review the
.tsx
file. - Looks like you might have possible left in some dependency requirements files that shouldn't have? 🤷
- I like the look of the button though from the vid-snippet you posted in the description.
I would have approved if it weren't for the package.json
and package-lock.json
.
@imaitland & @amitschang Looking at ssec-jhu/evolver-ng#200, I would think the UI needs a safety measure to account for someone hitting "play" when something is already running. Otherwise, it'll clobber everything (e.g., config on file) and restart. Opened #7 to account for this if @imaitland you'd prefer to punt. |
Do my comments regarding changes to package.json and package-lock.json make sense? Happy to break them out into a seperate pr, tho i don't think this is necessary here. |
@jamienoss what specifically does it clobber? My understanding is that sending a
so nothing should be clobbered (except those flags) by stopping and then starting the evolver? |
Re: #5 (comment) That's correct, but only if you abort first. It would be a shame to accidentally click |
start/stop as implemented in this pr is a toggle. So from a UX pov - you can't start an already running evolver. User can do whatever they want against the http api. If there needs to be a guard it should be on the device's |
Awesome! 👍 |
Basic PR adding play/pause functionality to the device, following PR will hook it up into the /abort endpoint.
open to feedback for icons and language...