Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vial layout #243

Merged
merged 2 commits into from
Jan 28, 2025
Merged

vial layout #243

merged 2 commits into from
Jan 28, 2025

Conversation

amitschang
Copy link
Member

@amitschang amitschang commented Jan 10, 2025

This adds configuration and validation for a grid layout specification. I'm not sure at the moment how else this needs to be presented or used in the backend, so it is just the configuration for now, which could be used in frontend for presentation.

resolves #153.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@amitschang amitschang marked this pull request as ready for review January 21, 2025 19:34
@amitschang amitschang requested a review from a team as a code owner January 21, 2025 19:34
@amitschang amitschang requested a review from imaitland January 21, 2025 19:34
@amitschang amitschang changed the title vial layout wip vial layout Jan 22, 2025
@imaitland imaitland self-requested a review January 22, 2025 16:59
Copy link
Collaborator

@imaitland imaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitschang amitschang merged commit 2163f1e into main Jan 28, 2025
8 checks passed
@amitschang amitschang deleted the gh-153-vial-layout branch January 28, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vial physical layout specification in evolver
2 participants