Updated member list to show offline members also. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r List. In room.coffee: returned offline for the status in the method userActiveByUsername. The method previously pulled the user from the session when doing the check. It disregarded it if the user was not in the session (offline). Commented out the base.less file that was overriding the status color in the member list.
|
Works for me 👍 I think we should sort alphabetically. Maybe group by status? FYI: Duplicate of RocketChat#337. You should create a pull request for RocketChat. Also, moderators suggest creating a configurable setting. |
|
Thanks Reid. I need to go through their issues a little closer! |
# Conflicts: # client/stylesheets/base.less # client/views/app/room.html
…yone in the room Removed offset Added profile first name and last name to user data publication Updated userObserve to include new profile fields Updated room to display first name and last name (sort by last name) instead of username
…blication because it now returns all users.
| @@ -105,16 +105,14 @@ Meteor.startup -> | |||
| return room?.dom? | |||
|
|
|||
| updateUserStatus = (user, status, utcOffset) -> | |||
| onlineUsersValue = onlineUsers.curValue | |||
| allUsersValue = allUsers.curValue | |||
There was a problem hiding this comment.
Does .curValue return the same thing as .get() for a reactive var?
There was a problem hiding this comment.
I dunno. I just changed their currrent one from online. You're much more familiar with it.
|
👍 |
|
What do you know, now there are conflicts to merge it back in 😞 |
# Conflicts: # client/views/app/room.coffee
bbrockman
added a commit
that referenced
this pull request
Aug 13, 2015
Updated member list to show offline members also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated member list to show offline users and color the names according to their status.
In room.coffee: returned offline for the status in the method userActiveByUsername. The method previously pulled the user from the session when doing the check. It disregarded it if the user was not in the session (offline).
Commented out the base.less file that was overriding the status color in the member list.