Added collapsable components under Channels, Direct Messages, and Private Groups #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Boostrap - Included only required components for collapsible functionality Added styles for collapsable components Added collapsable components under Channels, Direct Messages, and Private Groups
|
Verified it expands/collapses. 👍 Suggestions:
|
|
Good ideas. Just finished your first suggestion. I'll take a look at your second. |
1) Added logic to collapse to make sure there was at least 1 room/direct message/channel before adding the collapsible icon. 2) Aligned the collapsable icons to the icons above them.
|
Updated them both. Reid, |
|
nice. 👍 |
|
I like it. Looks good to me. |
| right: percentage((@columns / @grid-columns)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I like how 99% of the code change in this pull request is adding giant bootstrap files ;)
There was a problem hiding this comment.
All so I can use the collapse functionality.
# Conflicts: # .meteor/packages # client/stylesheets/base.less
* origin/master:
Fixed Indenting error! Thanks Coffee!
Added comment to not add additional fields to be returned with the publication because it now returns all users.
Removed logging
Updated onlineUsers to allUsers for rooms because we want to see everyone in the room Removed offset Added profile first name and last name to user data publication Updated userObserve to include new profile fields Updated room to display first name and last name (sort by last name) instead of username
Added status-{{status}} to paragraph that displayed username in Member List. In room.coffee: returned offline for the status in the method userActiveByUsername. The method previously pulled the user from the session when doing the check. It disregarded it if the user was not in the session (offline). Commented out the base.less file that was overriding the status color in the member list.
bbrockman
added a commit
that referenced
this pull request
Aug 13, 2015
Added collapsable components under Channels, Direct Messages, and Private Groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added collapsable components under Channels, Direct Messages, and Private Groups
Added Kadira Debug
Added Boostrap - Included only required components for collapsible functionality
Added styles for collapsable components