Chat locker 3 #18
Merged
Chat locker 3 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified 'directMessagesFlex' template to call the method whenever a target user is chosen, and then print out the resultant perms
…gging getting an unknown error
removed security labels from channels and added labels to direct messages and private groups Added chosen styles to match bootstrap 3
Added subscription to the 'room' publication for pulling relabel data
Added call to and created updatePrivateGroup
Put in the updateDirectMessage functionality
…ta context when flex template set
Requires relabelRoom method from issue 4
…late room fields on relabel
…into chat-locker-3
Updated comments.
…into chat-locker-3
rename a room to an existing room's name with the same name already exists.
…d in room id. Replaced it with code that retrieved the room from the session. The roomObserve code detects ChatRoom subscription changes and updates the session with key roomData + roomId. Also set the room name and members using the room object retrieve from the session.
consistency. Unfortunately, we should really use the fullname, but we can't because we're reusing this template to update a room and we currently don't have a way to retrieve a full name from a username.
1. check that room creator is not removed 2. relabel room if access permissions changed 3. add new members that we're previously in the room 4. remove existing members that should no longer be in the room
… any permissions assigned to them and is not restricted based on other members permissions. Made this change because of the UI. we create a room and allow the user to specify the members and access permissions at the same time. it would be confusing to constantly update the available access permissions every time user is added/removed from the room.
…ll label data even if user hasn't 'entered' room yet
…ication also changed
…ssages Fixed case where both members of direct message would get kicked on relabel Comments
…ssage in order to set security labels before creating the room. Previously, the right tab would create the direct message room (via createDirectMessage) method then route to the new room. Also removed the conversation button from the right flex tab when the user is viewing themself because they can't talk to themselves.
use RocketChat error class. Label now displayed for SCI/SAP when user doesn't have permissions of that type. Previously we showed labels common to all selected users.
private groups. WHen updating a room, classifications of lower priority are not displayed. also fixed a bug where the selected classification could not be reselected because it was disabled (select another classification then try to reselect the original classification).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.