Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RORDEV-1152] Compile modules test-utils and integration-tests with Scala 3.3.3 #992

Conversation

mgoworko
Copy link
Contributor

Modules test-utils and integrations-tests are now compiled with Scala 3 (v3.3.3 LTS). Library upgrades and minor code adjustments.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

@mgoworko mgoworko force-pushed the compile-tests-with-scala3 branch from 5e0df81 to 9178f46 Compare March 13, 2024 19:29
@coutoPL coutoPL self-requested a review March 13, 2024 20:50
Copy link
Collaborator

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge the current develop branch

@mgoworko mgoworko force-pushed the compile-tests-with-scala3 branch from 2d3e418 to 9178f46 Compare April 8, 2024 18:35
mgoworko added 2 commits April 8, 2024 20:38
…-scala3

# Conflicts:
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/AdminApiAuthMockSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/AdminApiWithDefaultRorIndexSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/ClusterApiSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/FipsSslSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/IndexLifecycleManagementApiSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/JwtAuthSuite.scala
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/base/XpackClusterWithRorNodesAndInternodeSslSuite.scala
@mgoworko mgoworko requested a review from coutoPL April 8, 2024 18:42
Copy link
Collaborator

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM
Let me prepare the epic branch for the scala 3 migration and we are ready to merge

@coutoPL coutoPL changed the title Compile modules test-utils and integration-tests with Scala 3.3.3 [RORDEV-1152]Compile modules test-utils and integration-tests with Scala 3.3.3 Apr 8, 2024
@coutoPL coutoPL changed the title [RORDEV-1152]Compile modules test-utils and integration-tests with Scala 3.3.3 [RORDEV-1152] Compile modules test-utils and integration-tests with Scala 3.3.3 Apr 8, 2024
@coutoPL coutoPL changed the base branch from develop to epic/RORDEV-1152_scala3_migration April 8, 2024 18:50
@coutoPL coutoPL merged commit eaf8088 into sscarduzio:epic/RORDEV-1152_scala3_migration Apr 8, 2024
1 check passed
coutoPL pushed a commit that referenced this pull request May 23, 2024
@mgoworko mgoworko deleted the compile-tests-with-scala3 branch May 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants