Configure and use isort 😍 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
copybara_332093853
branch
from
4f349c1 to
4e0110a
Compare
copybara-service
bot
changed the title
This should, eventually (with e.g. instructions in the contribution section, CI, etc.) make it easier to contribute to refex without breaking any style things. It also resolves a bunch of bad imports that are bad for various reasons (e.g. not moving the raw_ast import when it was renamed to ast_matchers, or stuff about whether typing is a third-party library, or...) Pretty much everything looks good. Humongous thanks to @timothycrosley and everyone on [isort issue #1486](PyCQA/isort#1486). This also lets me ignore the internal linter that keeps bugging me about where refex imports go. One would imagine they should go in the first-party section -- internal linter doesn't agree (for reasons described in that issue), but it's hard to standardize on a lint-unfriendly order without some tool like isort to help back me up. PiperOrigin-RevId: 336189960
copybara-service
bot
force-pushed
the
copybara_332093853
branch
from
4e0110a to
f55bd49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure and use isort 😍
This should, eventually (with e.g. instructions in the contribution section, CI, etc.) make it easier to contribute to refex without breaking any style things. It also resolves a bunch of bad imports that are bad for various reasons (e.g. not moving the raw_ast import when it was renamed to ast_matchers, or stuff about whether typing is a third-party library, or...)
Pretty much everything looks good. Humongous thanks to @timothycrosley and everyone on isort issue #1486.
This also lets me ignore the internal linter that keeps bugging me about where refex imports go. One would imagine they should go in the first-party section -- internal linter doesn't agree (for reasons described in that issue), but it's hard to standardize on a lint-unfriendly order without some tool like isort to help back me up.