Added Scalastyle

[cdalzell]

Added scalastyle to the project, but otherwise made no changes. I'll make a separate cleanup branch in my fork once this goes in because I thought the addition should stand by itself.

Scalastyle will execute as part of mvn compile. Errors and warnings will be logged to the console and scalastyle-output.xml in the root directory.

Scalastyle is currently configured in the pom.xml to only block compilation if a rule marked "error" is violated. Right now all rules are set to "warning" in the config file, so that shouldn't be an issue until someone locks the rules down further.

[sryza]

Thanks for putting this together @cdalzell! I applied it and took a look at the warnings. Do you know how to disable the warnings for magic numbers and wildcard imports?

[sryza]

nit: add a newline here

[cdalzell]

Whoops.. That's a pet peeve of mine too. :)

[cdalzell]

You can disable the rules in certain areas of code by using special comments (as noted in the scalastyle-config.xml). If you want them to not evaluate at all, just commenting them out or removing them from the config file will take care of that.

Were you wanting them totally disabled?

[sryza]

Yeah, I think wildcard imports are generally acceptable when enough classes are used, and magic numbers show up often enough in tests that reporting them will be more of a nuisance than a boon.

[cdalzell]

Alright, disabled both those rules

[sryza]

Wunderbar, merging this