-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update completion behavior #244
Conversation
I will try this, and give you some feedback |
@edelvalle thanks |
@edelvalle due to I did lots of changes in |
|
||
parameters = get_function_parameters(in_call) | ||
logger.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the message be error-level like? do we mean this is an error or "JFYI" message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it would happen in weird occasions and does not break stuff... so a warning should do.
c01a183
to
0cd96bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks good to me but, I will pull it into my sublime and use it the rest of the week to see how it behaves.
I will tell you on Saturday if something went weird...
|
||
parameters = get_function_parameters(in_call) | ||
logger.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it would happen in weird occasions and does not break stuff... so a warning should do.
Using goto definition fails...
|
#254 Fixes this, but don't merge yet. I still evaluating... |
Fix missing import
This is ready, I had no problems with it for the past weeks! |
@edelvalle thanks for testing session! ⭐️ |
sublime.EventListerner
->sublime.ViewEventListener
utils.py
todaemon.py
daemon.py
tofacade.py