feat: Implement running multiple servers #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Nginxs class which contains masters and config objects - Manage all the I/O operations with one poll() in Nginxs class Additional Tasks - Move .conf file set to conf directory Co-authored-by: heehkim <[email protected]>
Closed
srngch
reviewed
Oct 23, 2022
| std::vector<Worker *>::iterator itBegin = workers_.begin(); | ||
| std::vector<Worker *>::iterator itEnd = workers_.end(); | ||
|
|
||
| while (itBegin != itEnd) { |
There was a problem hiding this comment.
이 부분에서 leak 문제 없을까요? for문으로 사용할 수 없을지 검색해보다가, 포인터 배열 다루다가 메모리 누수 많이 난다고 봐서요..!
There was a problem hiding this comment.
앗 찾았습니다... for문으로 바꾸는 게 깔끔할 것 같아요~! 저거 작성할 때는 저희가 이터레이터 쓰는 방법을 잘 모를 때 저렇게 작성했던 것 같습니다. 이전에 Master에 있던 코드 그대로입니다..
누수는 추후에 리팩토링 하면서 다시 확인해봐야 할 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
리뷰어에게