Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ssh public keys under ssh-pub-keys in topo json #2387

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 11, 2025

For external systems acting on containerlab topologies and creating automations around the nodes spawned with Containerlab it is beneficial to export the SSH public keys that containerlab extracted during its run.

This will enable tools to read the topology json and potentially add those keys at the post-deploy stage using automation tools available to a user

@hellt hellt merged commit 38ea59a into main Jan 11, 2025
66 of 67 checks passed
@hellt hellt deleted the ssh-pub-keys-in-topo-export branch January 11, 2025 15:48
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.88%. Comparing base (dd321ab) to head (02bf3cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   51.91%   51.88%   -0.03%     
==========================================
  Files         173      172       -1     
  Lines       17299    17302       +3     
==========================================
- Hits         8980     8978       -2     
- Misses       7378     7381       +3     
- Partials      941      943       +2     
Files with missing lines Coverage Δ
clab/export.go 75.32% <100.00%> (+5.58%) ⬆️
nodes/srl/version.go 75.43% <100.00%> (ø)
utils/ssh.go 91.66% <100.00%> (+8.33%) ⬆️

... and 2 files with indirect coverage changes

@FloSch62
Copy link
Member

Cool, I can use that for the clab connector too

@hellt
Copy link
Member Author

hellt commented Jan 11, 2025

yup, I did it for the NodeUser generation specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants