Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "docker outside of docker" devcontainer #2316

Merged
merged 39 commits into from
Dec 1, 2024
Merged

Added "docker outside of docker" devcontainer #2316

merged 39 commits into from
Dec 1, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 28, 2024

This PR takes the devcontainer machiner to another level.

Besides the standard docker in docker (dind) variant I have added the "docker outside of docker (aka dood)" which uses the parent docker without penalties of the docker in docker.

Besides, both dind and dood variants also got -slim versions which do not have go deps and py deps installed.
There is still a lot of work to slimify them, since the base py3.11 image from msft is heavy by itself. Maybe this is for later

@hellt hellt marked this pull request as ready for review November 29, 2024 22:29
@hellt hellt merged commit 3dbe819 into main Dec 1, 2024
2 of 3 checks passed
@hellt hellt deleted the devcontainer-dod branch December 1, 2024 00:39
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (2269834) to head (21c0860).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2316   +/-   ##
=======================================
  Coverage   51.35%   51.35%           
=======================================
  Files         172      172           
  Lines       16830    16830           
=======================================
  Hits         8643     8643           
  Misses       7262     7262           
  Partials      925      925           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant