Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/api overhaul #80

Merged
merged 18 commits into from
Dec 2, 2023
Merged

Refactor/api overhaul #80

merged 18 commits into from
Dec 2, 2023

Conversation

carlmontanari
Copy link
Contributor

very breaking changes mostly due to config (or topology in kne crd) -> definition field.

its going to get worse before it gets better 🤣

"flattening" the api package since there is no need for more hierarchy there.
flattened the controllers, well... controller now to align w/ the api changes

todo (maybe in a new pr if/when this gets merged?):

  • add a global config crd singleton
  • possibly add a validating web hook to enforce only one kind of topology in new definition field

@carlmontanari carlmontanari marked this pull request as ready for review December 2, 2023 20:02
@carlmontanari carlmontanari merged commit c4c44e2 into main Dec 2, 2023
4 checks passed
@carlmontanari carlmontanari deleted the refactor/api-overhaul branch December 2, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant