Feat/config resource defaults #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
reviewed
Oct 20, 2023
| @@ -90,6 +91,12 @@ type TopologyCommonSpec struct { | |||
| // +kubebuilder:validation:Enum=disabled;critical;warn;info;debug | |||
| // +optional | |||
| LauncherLogLevel string `json:"launcherLogLevel,omitempty"` | |||
| // Resources is a mapping of nodeName (or "default") to kubernetes resource requirements -- any | |||
There was a problem hiding this comment.
what does default key mean? Is it a requirement that is applied to all topology nodes?
There was a problem hiding this comment.
yeah exactly, will add some more clarity to that doc
carlmontanari
force-pushed
the
feat/config-resource-defaults
branch
from
a60d8a3 to
9e4e4ed
Compare
carlmontanari
force-pushed
the
feat/config-resource-defaults
branch
from
c06c2d4 to
28014e3
Compare
carlmontanari
force-pushed
the
feat/config-resource-defaults
branch
from
8864af7 to
2bebd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.