feat: add specsFile to clabverter #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2024 23:07
|
boom! very nice! will check it out and comment hopefully tomorrow but if not this weekend! |
thanks, in the meantime I'll have a look at that lint error |
| statusProbes: | ||
| enabled: true | ||
| excludedNodes: | ||
| - baguette |
hellt
reviewed
Jun 7, 2024
cmd/clabverter/cli/entrypoint.go
Outdated
| @@ -9,6 +9,7 @@ import ( | |||
|
|
|||
| const ( | |||
| topologyFile = "topologyFile" | |||
| specsFile = "specsFile" | |||
There was a problem hiding this comment.
I am rooting for shorter arg names, but for this feature I fail to find one.
Maybe though it should be --topoSpecFile (or --topoSpec) to be precise what it is about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--specsFileclabverter option allows to point to a yaml file containing values to be included in the output. More specifically in thespecsfield of the topology manifest.The value of
specsFileis to be able to share values of a shared cluster across all users, especially when not all users are comfortable with k8s/c9s.