Clabverter : ensure deletion of the old clabverter logging instance before creating a new one #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +54,11 @@ func MustNewClabverter( | |||
|
|
|||
| logManager := claberneteslogging.GetManager() | |||
|
|
|||
| oldClabverterLogger, _ := logManager.GetLogger(clabernetesconstants.Clabverter) | |||
There was a problem hiding this comment.
I wonder if it exists we should just return it instead? That way other stuff won’t end up with some deleted/nil logger?
There was a problem hiding this comment.
Is the logger always have the same configuration at the end ? If it's different and comes from an old, destroyed Clabverter instance, that might cause issues.
If not I can change my PR to use the old one 😃
There was a problem hiding this comment.
ah, sorry ignore me anyway hah. I looked on my phone and didn't see where this was happening. this works for me :p
|
lgtm, thanks @outout14 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using Clabverter as a Golang module, we need to use the
MustNewClabverter()function to create a new clabverter instance.The functions calls
MustRegisterAndGetLogger()that panics if a logging instance of clabverter already exists.This PR patches the
MustNewClabverterby checking if the logging instance already exists. If so, it get destroyed and recreated.