Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an unlisted metadata property #318

Closed
wants to merge 3 commits into from
Closed

Add an unlisted metadata property #318

wants to merge 3 commits into from

Conversation

amir
Copy link
Contributor

@amir amir commented Aug 2, 2020

Addresses #158

@srid
Copy link
Owner

srid commented Aug 2, 2020

@amir Does this still generate the .html for the unlisted zettel?

@amir
Copy link
Contributor Author

amir commented Aug 5, 2020

@srid yes, it does.

srid
srid reviewed Aug 5, 2020
View reviewed changes
neuron/src/app/Neuron/Reader/Org.hs
pure $ Just Meta {..}
| otherwise = pure Nothing
where
parseDate :: Text -> Either ZettelParseError Day
parseDate date = maybeToRight (Tagged $ "Invalid date format: " <> date) $ parseZettelDate @Maybe date

parseUnlisted :: Text -> Bool
parseUnlisted a = toLower a == "true"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felko Does this look right? I'm not familiar with org.

@amir amir force-pushed the 158/unlisted-property branch from 862e0d1 to bc102b1 Compare August 5, 2020 17:26
srid pushed a commit that referenced this pull request Aug 5, 2020
@amir @srid
Add an unlisted metadata property (#318)
0cf2d87 
Squashed commit of the following:

commit bc102b1
Author: Amir Saeid <[email protected]>
Date:   Wed Aug 5 18:25:39 2020 +0100

    format

commit 09e7224
Author: Amir Saeid <[email protected]>
Date:   Wed Aug 5 17:50:40 2020 +0100

    Update CHANGELOG

commit e226268
Author: Amir Saeid <[email protected]>
Date:   Sun Aug 2 14:29:00 2020 +0100

    Add an unlisted metadata property

    Addresses #158
@srid
Copy link
Owner

srid commented Aug 5, 2020

Merged in #325

@srid srid closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid left review comments

Assignees
No one assigned
Labels
Impacts JSON API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amir @srid