Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run preparePandoc in parseNoteOrg and parseNoteMarkdown #446

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

kukimik
Copy link
Contributor

@kukimik kukimik commented Jun 26, 2023

This implements the TODO from

-- TODO: Run this in `parseNote`?

I needed this for my failed approach at #167. I think this does not break anything and moreover it even fixes a bug: the font-family: emoji style was not applied to the emoji in wikilink descriptions (this happened both in note body and in backlinks). See the screenshot of http://emanote.srid.ca/guide:

obraz

Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. I don't remember anymore why I wrote code that way, but something broke when I did this back then.

@srid srid merged commit 3f33109 into srid:master Jun 26, 2023
shivaraj-bh pushed a commit to shivaraj-bh/emanote that referenced this pull request Dec 18, 2023
* run `preparePandoc` in `parseNoteOrg` and `parseNoteMarkdown`

* Increment version

---------

Co-authored-by: Sridhar Ratnakumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants