Skip to content
This repository has been archived by the owner on Dec 29, 2023. It is now read-only.

Fix Windows shortcut #205

Merged
merged 9 commits into from
Jan 11, 2021
Merged

Fix Windows shortcut #205

merged 9 commits into from
Jan 11, 2021

Conversation

levirs565
Copy link
Contributor

This fix Windows Shortcut problem. To create shortcut run this code in python:

from guiscrcpy.platform.windows_tools.tools import make_shortcut
make_shortcut()

Changes:

  • Minimum Python version is Python 3.7
  • guiscrcpy_logo_SRj_icon.ico is added to package_data
  • Add guiscrcpy-noconsole gui scripts
  • Use wrapped Popen function to run command

@levirs565 levirs565 mentioned this pull request Jan 11, 2021
Closed
srevinsaju
srevinsaju reviewed Jan 11, 2021
View reviewed changes
Copy link
Owner

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks for the Pull Request. Looks good, but a few doubts

guiscrcpy/lib/utils.py Outdated Show resolved Hide resolved
@levirs565
Copy link
Contributor Author

I haven't checked whether all the features work well.

@srevinsaju
Copy link
Owner

srevinsaju commented Jan 11, 2021 •
edited
Loading

I haven't checked whether all the features work well.

The tests would ensure that all features work properly, right now.. the tests have failed :P
looks like a minor formatting problem. Should be solved by running black.

pip3 install black
black guiscrcpy

would format all of them. More info here

@levirs565
Copy link
Contributor Author

I have finished improving the code. But there are Codacy security issues

@srevinsaju
Copy link
Owner

srevinsaju commented Jan 11, 2021 •
edited by unfurl-links bot
Loading

@levirs565 the tests are still failing: https://github.com/srevinsaju/guiscrcpy/pull/205/checks?check_run_id=1681436824

GitHub
This fix Windows Shortcut problem. To create shortcut run this code in python: from guiscrcpy.platform.windows_tools.tools import make_shortcut make_shortcut() Changes:

Minimum Python version is P...

@levirs565
Copy link
Contributor Author

levirs565 commented Jan 11, 2021 •
edited by unfurl-links bot
Loading

Please check latest commit tests. This has been fixed. See this test https://github.com/srevinsaju/guiscrcpy/pull/205/checks?check_run_id=1681483802

GitHub
This fix Windows Shortcut problem. To create shortcut run this code in python: from guiscrcpy.platform.windows_tools.tools import make_shortcut make_shortcut() Changes:

Minimum Python version is P...

@srevinsaju
Copy link
Owner

thanks, looks good. I will do a final review and merge.

@srevinsaju srevinsaju merged commit 1dc430d into srevinsaju:master Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srevinsaju srevinsaju srevinsaju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levirs565 @srevinsaju