create default user #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
reviewed
May 20, 2019
docker-compose.yml
Outdated
| ADMIN_LOGIN: admin | ||
| ADMIN_FIRST_NAME: admin | ||
| ADMIN_LAST_NAME: admin | ||
| ADMIN_EMAIL: [email protected] |
There was a problem hiding this comment.
I'm not familiar with no-email.org, maybe it's safer to use [email protected], since it's owned by IANA
carlosms
suggested changes
May 20, 2019
|
carlosms
reviewed
May 21, 2019
There was a problem hiding this comment.
I'm thinking that maybe it's better to leave the code in docker-init.sh and call it from docker-entrypoint.sh. After #59, if docker-init.sh gets some changes in upstream we will be able to merge them, but if the file disappears we will miss those changes.
|
Tienes razón! I'll wait for that PR to be merged and then update preserving the init script. |
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
|
Rebased on master. Don't forget to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #11