-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables overflow the chart container #114
Comments
@smacker @ricardobaeta isn't this caused (or fixed) by some layout or overflow property? |
most probably it's possible to fix by overflow property but it may break some other things. |
@marnovo @smacker This is caused by a margin-bottom attributed to the Chart Title, on the Typography PR. I will check with @dpordomingo this and tackle the issue. |
@ricardobaeta please make sure to test this broadly with the built-in and new charts of varied types/sizes. |
This commit will solve issue #114. Signed-off-by: Ricardo Baeta <[email protected]>
@marnovo I've tested the built-in charts, and it's all fine. The only built-in chart that is not good is the "Welcome" > "Files missing summary" that's issued here. We can make it look good when we're updating this dashboard with the welcome text and the progress bars, changing its height on "Edit Dashboard" before we update it. The new charts of varied types/sizes were tested, and it's all good as well, given that the solution applies also to all new charts, and moreover we can control the width & height of new charts when we're creating/editing a new dashboard. |
This commit will solve issue src-d#114. Signed-off-by: Ricardo Baeta <[email protected]>
This commit will solve issue src-d#114. Signed-off-by: Ricardo Baeta <[email protected]>
I thought it would be possible to fix with making the container bigger but it fixes the issue only when the table is small. For a table with many elements changing size of the chart doesn't help.
The text was updated successfully, but these errors were encountered: