Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables overflow the chart container #114

Closed
smacker opened this issue Jun 17, 2019 · 5 comments · Fixed by #139
Closed

Tables overflow the chart container #114

smacker opened this issue Jun 17, 2019 · 5 comments · Fixed by #139
Assignees
Labels
bug Something isn't working product-design Visual, branding, typography

Comments

@smacker
Copy link
Contributor

smacker commented Jun 17, 2019

Screenshot 2019-06-17 at 12 22 20

I thought it would be possible to fix with making the container bigger but it fixes the issue only when the table is small. For a table with many elements changing size of the chart doesn't help.

@carlosms carlosms added the bug Something isn't working label Jun 18, 2019
@marnovo
Copy link
Member

marnovo commented Jun 20, 2019

@smacker @ricardobaeta isn't this caused (or fixed) by some layout or overflow property?

@smacker
Copy link
Contributor Author

smacker commented Jun 20, 2019

most probably it's possible to fix by overflow property but it may break some other things.
Anyway, I didn't have time to dig deep into it and trust Ricardo for a proper fix.

@ricardobaeta
Copy link
Contributor

ricardobaeta commented Jun 20, 2019

@marnovo @smacker This is caused by a margin-bottom attributed to the Chart Title, on the Typography PR. I will check with @dpordomingo this and tackle the issue.

image

@marnovo
Copy link
Member

marnovo commented Jun 20, 2019

@ricardobaeta please make sure to test this broadly with the built-in and new charts of varied types/sizes.

ricardobaeta added a commit that referenced this issue Jun 20, 2019
This commit will solve issue #114.

Signed-off-by: Ricardo Baeta <[email protected]>
@dpordomingo dpordomingo added the product-design Visual, branding, typography label Jun 20, 2019
@ricardobaeta
Copy link
Contributor

@marnovo I've tested the built-in charts, and it's all fine. The only built-in chart that is not good is the "Welcome" > "Files missing summary" that's issued here. We can make it look good when we're updating this dashboard with the welcome text and the progress bars, changing its height on "Edit Dashboard" before we update it.

The new charts of varied types/sizes were tested, and it's all good as well, given that the solution applies also to all new charts, and moreover we can control the width & height of new charts when we're creating/editing a new dashboard.

dpordomingo pushed a commit to dpordomingo/sourced-ui that referenced this issue Jun 27, 2019
This commit will solve issue src-d#114.

Signed-off-by: Ricardo Baeta <[email protected]>
dpordomingo pushed a commit to dpordomingo/sourced-ui that referenced this issue Jul 2, 2019
This commit will solve issue src-d#114.

Signed-off-by: Ricardo Baeta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product-design Visual, branding, typography
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants