Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump changelog for v0.16.0 #244

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Bump changelog for v0.16.0 #244

merged 3 commits into from
Sep 16, 2019

Conversation

carlosms
Copy link
Contributor

Updates bblfsh-web and sourced-ui, plus bumps the changelog for v0.16.0


  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@carlosms carlosms requested a review from a team September 16, 2019 11:10
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I wonder if it would be nice to expose the major changes of the bumped libs, to avoid the user go to its changelogs to find what relevant changes to expect.

@dpordomingo
Copy link
Contributor

for example, I'd mention that:

  • xPath UAST filter now works with results that are plain values
  • sql lab supports spark query cancellation
  • charts uses new color palettes with source{d} brand colors
  • smaller sourced-ui image size

Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Copy link
Contributor Author

Good idea. I'd say let's skip for this one, and do for the next releases. Or do it for this 0.16 release, but afterwards.
I think it needs to be a hand-crafted approach instead of just a plain summary of the other changelogs. For example, spark features in sourced-ui are not relevant to sourced-ce users (yet).

@carlosms carlosms merged commit 4283ad0 into src-d:master Sep 16, 2019
@dpordomingo
Copy link
Contributor

Agree with your proposal and about the necessity of doing it by hand, to extract only relevant features for the end user.

Also agree with your proposal of doing it for next releases.

@carlosms carlosms deleted the bump-v0.16.0 branch September 17, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants