Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web sql: Click on tables & sample queries works inconsistently #350

Open
smacker opened this issue Mar 4, 2019 · 1 comment
Open

web sql: Click on tables & sample queries works inconsistently #350

smacker opened this issue Mar 4, 2019 · 1 comment
Labels
empathy-sessions Issue filed as as part of empathy sessions triage/needs-product-input

Comments

@smacker
Copy link
Contributor

smacker commented Mar 4, 2019

On tables it runs query but examples only changes input.

@carlosms carlosms transferred this issue from src-d/engine-deprecated Mar 5, 2019
@carlosms
Copy link
Contributor

carlosms commented Mar 5, 2019

For context: both of them worked similarly. Then in #209 we removed the autorun for the sample queries.

On one hand I agree with having consistency. On the other hand, the rationale from #209 does not apply to a DESCRIBE TABLE

Rationale: often you want to edit the query before running it or just to see the query for inspiration

@carlosms carlosms added the empathy-sessions Issue filed as as part of empathy sessions label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
empathy-sessions Issue filed as as part of empathy sessions triage/needs-product-input
Projects
None yet
Development

No branches or pull requests

2 participants