Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autorun sample queries #209

Closed
eiso opened this issue Aug 14, 2018 · 5 comments
Closed

Do not autorun sample queries #209

eiso opened this issue Aug 14, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@eiso
Copy link
Member

eiso commented Aug 14, 2018

I would disable the autorun on sample queries and instead, have it just populate the query field.

Rationale: often you want to edit the query before running it or just to see the query for inspiration

@eiso eiso added the enhancement New feature or request label Aug 14, 2018
@carlosms
Copy link
Contributor

pinging @ricardobaeta for UX suggestions

@ricardobaeta
Copy link

I understand the rationale, and I agree. Although, it sparkles another idea in my mind: when you click on a sample query, it opens a new tab, but if we're not going to run it, does it makes sense if I click on other example query to just update the query on that tab that didn't run, or open a new tab?

@carlosms
Copy link
Contributor

I think maybe you are mixing the current design with the future changes you have in mind :)
Right now the new tabs are created only when the query is run. So if we remove autorun, clicking on example queries will not create a new tab, and cliking on the next example will only update the main query box.

@ricardobaeta
Copy link

Thanks @carlosms , this is perfect.

@bzz
Copy link
Contributor

bzz commented Aug 14, 2018

👍 Nice suggestion, totally agree, we even discussed that with @ricardobaeta couple of times at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants