Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a check if nltk resource already exists to avoid downloading ev… #98

Merged
merged 1 commit into from
Aug 6, 2023
Merged

added a check if nltk resource already exists to avoid downloading ev… #98

merged 1 commit into from
Aug 6, 2023

Conversation

sanketkhajuria
Copy link

…erytime the app loads

Pull Request Title

Related Issue

fixes #94

Description

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

Screenshots / Code Snippets (if applicable)

How to Test

  1. Run the app.
  2. Interact with the resume selector slider
  3. Notice the console for logs.

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

srbhr
srbhr approved these changes Aug 6, 2023
View reviewed changes
Copy link
Owner

@srbhr srbhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanketkhajuria thanks for this PR. Approved!

@srbhr srbhr merged commit c5eb4c6 into srbhr:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbhr srbhr srbhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It tries to install nltk resource everytime user interacts with the webpage.
2 participants
@sanketkhajuria @srbhr