Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context sensitive keywords support #836

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Context sensitive keywords support #836

merged 1 commit into from
Jan 13, 2016

Conversation

kukulich
Copy link
Contributor

No description provided.

@gsherwood
Copy link
Member

I wonder if it might be easier to think about what tokens are allowed after const, function and :: rather than maintain the blacklist. It might be as short as:

  • T_STRING
  • T_VARIABLE
  • T_DOLLAR
  • T_OPEN_PARENTHESIS
  • A few more I'm sure I have forgotten

@kukulich
Copy link
Contributor Author

@gsherwood Ok, I have just forcepushed new version.

@gsherwood gsherwood merged commit 5729980 into squizlabs:master Jan 13, 2016
@gsherwood
Copy link
Member

Thanks a lot for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants