-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitLab Code Climate report #3749
Open
KamiYang
wants to merge
1
commit into
squizlabs:master
Choose a base branch
from
KamiYang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
<?php | ||
/** | ||
* GitLab Code Climate report for PHP_CodeSniffer. | ||
* | ||
* @author Greg Sherwood <[email protected]> | ||
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600) | ||
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence | ||
*/ | ||
|
||
namespace PHP_CodeSniffer\Reports; | ||
|
||
use PHP_CodeSniffer\Files\File; | ||
|
||
class GitlabCodeclimate implements Report | ||
{ | ||
|
||
/** | ||
* A numeric to string map of severity keywords. | ||
* | ||
* @var string[] | ||
*/ | ||
private static $severityMap = [ | ||
1 => 'info', | ||
2 => 'minor', | ||
3 => 'major', | ||
4 => 'critical', | ||
5 => 'blocker', | ||
]; | ||
|
||
|
||
/** | ||
* Generate a partial report for a single processed file. | ||
* | ||
* Function should return TRUE if it printed or stored data about the file | ||
* and FALSE if it ignored the file. Returning TRUE indicates that the file and | ||
* its data should be counted in the grand totals. | ||
* | ||
* @param array $report Prepared report data. | ||
* @param \PHP_CodeSniffer\File $phpcsFile The file being reported on. | ||
* @param bool $showSources Show sources? | ||
* @param int $width Maximum allowed line width. | ||
* | ||
* @return bool | ||
*/ | ||
public function generateFileReport($report, File $phpcsFile, $showSources=false, $width=80) | ||
{ | ||
if ((int) $report['errors'] === 0 && (int) $report['warnings'] === 0) { | ||
return false; | ||
} | ||
|
||
$messages = ''; | ||
foreach ($report['messages'] as $line => $lineErrors) { | ||
foreach ($lineErrors as $column => $colErrors) { | ||
foreach ($colErrors as $error) { | ||
$messageObject = [ | ||
'categories' => ['Bug Risk'], | ||
'check_name' => $error['source'], | ||
'description' => $error['message'], | ||
'fingerprint' => sha1("{$report['filename']}:{$line}:{$column}:{$error['message']}"), | ||
'location' => [ | ||
'path' => $report['filename'], | ||
'lines' => ['begin' => $line], | ||
], | ||
'severity' => self::$severityMap[(int) $error['severity']], | ||
'type' => 'issue', | ||
]; | ||
|
||
$messages .= json_encode($messageObject).','; | ||
} | ||
}//end foreach | ||
}//end foreach | ||
|
||
echo $messages; | ||
|
||
return true; | ||
|
||
}//end generateFileReport() | ||
|
||
|
||
/** | ||
* Generates a GitLab Code Climate report. | ||
* | ||
* @param string $cachedData Any partial report data that was returned from | ||
* generateFileReport during the run. | ||
* @param int $totalFiles Total number of files processed during the run. | ||
* @param int $totalErrors Total number of errors found during the run. | ||
* @param int $totalWarnings Total number of warnings found during the run. | ||
* @param int $totalFixable Total number of problems that can be fixed. | ||
* @param bool $showSources Show sources? | ||
* @param int $width Maximum allowed line width. | ||
* @param bool $interactive Are we running in interactive mode? | ||
* @param bool $toScreen Is the report being printed to screen? | ||
* | ||
* @return void | ||
*/ | ||
public function generate( | ||
$cachedData, | ||
$totalFiles, | ||
$totalErrors, | ||
$totalWarnings, | ||
$totalFixable, | ||
$showSources=false, | ||
$width=80, | ||
$interactive=false, | ||
$toScreen=true | ||
) { | ||
echo '['; | ||
echo rtrim($cachedData, ','); | ||
echo ']'.PHP_EOL; | ||
|
||
}//end generate() | ||
|
||
|
||
}//end class |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding (I'm not at all accustomed to phpcs internals btw) - you have to JSON encode each error on its own and use string concatenation because the reporter is expected to print here, right? Which is why json encoding an array of errors does not work and why
generate()
below needs to add the JSON array brackets I suppose?