New Generic.WhiteSpace.SpreadOperatorSpacingAfter sniff (PSR12 related) #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I can actually include this in PSR12 because people tend to get angry when PHPCS enforces rules that the standard doesn't explicitly describe. But it's a very useful sniff regardless. |
|
Yes, I noticed you'd added a different sniff for PSR12. Shall I remove the PSR12 ruleset change from the PR so this can be merged for anyone who does want a more extensive check for the spread operator ? |
Yes please, if you have time. |
jrfnl
force-pushed
the
feature/new-spread-operator-spacing-sniff
branch
from
b6fb00f to
5c82a94
Compare
|
Easy-peasy. Done. |
This introduces a new sniff which checks the whitespace between the spread operator and the variable/function call it applies to. This new sniff has two `public` properties: * `$spacing` which defaults to `0`, i.e. no space. * `$ignoreNewlines` which defaults to `false`. Includes unit tests. Includes fixers. Includes documentation. Note: PSR12 only specifies _There MUST NOT be a space between the variadic three dot operator and the argument name_ for **function declarations**. This sniff, however, checks the spacing for the spread operator in all circumstances in which it can be used, i.e.: * In function declarations (PHP 5.6). * In function calls (PHP 5.6). * In array declarations (PHP 7.4).
|
Thanks a lot for making that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new sniff which checks the whitespace between the spread operator and the variable/function call it applies to.
This new sniff has two
publicproperties:$spacingwhich defaults to0, i.e. no space.$ignoreNewlineswhich defaults tofalse.Includes unit tests.
Includes fixers.
Includes documentation.
Includes adding this sniff to the PSR12 ruleset.Note: PSR12 only specifies There MUST NOT be a space between the variadic three dot operator and the argument name for function declarations.
This sniff, however, checks the spacing for the spread operator in all circumstances in which it can be used, i.e.: