Fix abstract/interface methods in PEAR.Functions.FunctionDeclaration #2148
Conversation
| @@ -105,7 +105,7 @@ public function process(File $phpcsFile, $stackPtr) | |||
| // Unfinished closures are tokenized as T_FUNCTION however, and can be excluded | |||
| // by checking for the scope_opener. | |||
| if ($tokens[$stackPtr]['code'] === T_FUNCTION | |||
| && isset($tokens[$stackPtr]['scope_opener']) === true | |||
| && (isset($tokens[$stackPtr]['scope_opener']) === true || $tokens[$stackPtr]['level'] === 1) | |||
There was a problem hiding this comment.
I don't think that checking the token level is the best way to do this. It wouldn't work, for example, if you had the class wrapped in a condition (like an autoloader maybe) and while I can't think of why you'd define an abstract method in an anon class, it wouldn't catch that either. It's probably best to call File::getMethodProperties() and check the isAbstract array index to be sure.
There was a problem hiding this comment.
Added a failing test in eeb758a, will have another look at the implementation.
thewilkybarkid
force-pushed
the
function-declaration-no-body
branch
from
80a1e00 to
3ef5716
Compare
|
@gsherwood Couldn't use |
|
Thanks a lot for making those changes and including tests. |
Currently methods without a body fail to have the whitespace before the opening parenthesis and before the semicolon removed.