Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic.Formatting.MultipleStatementAlignment does see PHP close tag as end of statement block #2018

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented May 15, 2018

The case where PHP and HTML is mixed was not taken into account by the sniff up to now.

Includes unit test.

…when a PHP close tag is encountered

Includes unit test.
@gsherwood gsherwood changed the title Generic/MultipleStatementAlignment: break out of the statement block when a PHP close tag is encountered Generic.Formatting.MultipleStatementAlignment does see PHP close tag as end of statement block May 18, 2018
@gsherwood gsherwood added this to the 3.3.0 milestone May 18, 2018
@gsherwood gsherwood merged commit f94d7d8 into squizlabs:master May 18, 2018
gsherwood added a commit that referenced this pull request May 18, 2018
@gsherwood
Copy link
Member

Thanks for fixing this.

@jrfnl jrfnl deleted the feature/generic-multiplestatementalignment-allow-for-php-close-tag branch May 18, 2018 07:02
@jrfnl
Copy link
Contributor Author

jrfnl commented May 18, 2018

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants