Custom property arrays: be lenient about space usage #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is debatable whether it is a bug or a feature that custom property arrays are unforgiving about spaces surrounding the individual keys and values, all custom properties in PHPCS itself do not expect spaces around them.
This minor change removes spaces around array keys and values before the property is passed to the sniff.
This means that each of the below examples will now result in the same property value being set:
```xml
<rule ref="Generic.PHP.ForbiddenFunctions">
<properties>
<property name="forbiddenFunctions" value="print=>echo,create_function=>null" type="array" />
<property name="forbiddenFunctions" value="print=>echo, create_function=>null" type="array" />
<property name="forbiddenFunctions" value="print => echo, create_function => null" type="array" />
</properties>
</rule>
```
Fixes 1688
This was referenced Oct 7, 2017
23 tasks
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is debatable whether it is a bug or a feature that custom property arrays are unforgiving about spaces surrounding the individual keys and values, all custom array properties in PHPCS itself do not expect spaces around them.
This minor change removes spaces around array keys and values before the property is passed to the sniff.
This means that each of the below examples will now result in the same property value being set:
Fixes #1688