Squiz.Strings.DoubleQuoteUsage replaces tabs with spaces when fixing

src/Standards/Squiz/Sniffs/Strings/DoubleQuoteUsageSniff.php

@@ -44,34 +44,37 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
-        // We are only interested in the first token in a multi-line string.
-        if ($tokens[$stackPtr]['code'] === $tokens[($stackPtr - 1)]['code']) {
-            return;
+        // If tabs are being converted to spaces by the tokeniser, the
+        // original content should be used instead of the converted content.
+        if (isset($tokens[$stackPtr]['orig_content']) === true) {
+            $workingString = $tokens[$stackPtr]['orig_content'];
+        } else {
+            $workingString = $tokens[$stackPtr]['content'];
         }
 
-        $workingString   = $tokens[$stackPtr]['content'];
         $lastStringToken = $stackPtr;
 
         $i = ($stackPtr + 1);
         if (isset($tokens[$i]) === true) {
             while ($i < $phpcsFile->numTokens
                 && $tokens[$i]['code'] === $tokens[$stackPtr]['code']
             ) {
-                $workingString  .= $tokens[$i]['content'];
+                if (isset($tokens[$i]['orig_content']) === true) {
+                    $workingString .= $tokens[$i]['orig_content'];
+                } else {
+                    $workingString .= $tokens[$i]['content'];
+                }
+
                 $lastStringToken = $i;
                 $i++;
             }
         }
 
-        // Check if it's a double quoted string.
-        if (strpos($workingString, '"') === false) {
-            return;
-        }
+        $skipTo = ($lastStringToken + 1);
 
-        // Make sure it's not a part of a string started in a previous line.
-        // If it is, then we have already checked it.
-        if ($workingString[0] !== '"') {
-            return;
+        // Check if it's a double quoted string.
+        if ($workingString[0] !== '"' || substr($workingString, -1) !== '"') {
+            return $skipTo;
         }
 
         // The use of variables in double quoted strings is not allowed.
@@ -85,7 +88,7 @@ public function process(File $phpcsFile, $stackPtr)
                 }
             }
 
-            return;
+            return $skipTo;
         }//end if
 
         $allowedChars = array(
@@ -111,7 +114,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         foreach ($allowedChars as $testChar) {
             if (strpos($workingString, $testChar) !== false) {
-                return;
+                return $skipTo;
             }
         }
 
@@ -133,6 +136,8 @@ public function process(File $phpcsFile, $stackPtr)
             $phpcsFile->fixer->endChangeset();
         }
 
+        return $skipTo;
+
     }//end process()
 
 

src/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.inc

@@ -29,6 +29,9 @@ $string = "\123 \234"."\u123"."\e";
 echo "window.location = \"".$url."\";\n";
 echo ""
 
+$string = "Hello
+			there";
+
 function test() {
     echo "It Worked';
 }

src/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.inc.fixed

@@ -29,6 +29,9 @@ $string = "\123 \234"."\u123"."\e";
 echo 'window.location = "'.$url."\";\n";
 echo ''
 
+$string = 'Hello
+			there';
+
 function test() {
     echo "It Worked';
 }

src/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.php

@@ -38,6 +38,7 @@ public function getErrorList()
                 22 => 1,
                 29 => 1,
                 30 => 1,
+                32 => 1,
                );
 
     }//end getErrorList()