Tokenizer bug with docblocks in CSS #2219
Comments
|
The CSS support will be dropped anyway #2448 |
|
@VincentLanglet I know. You did see that this issue pre-dates the announcement that support will be dropped by about five months ? And that the drop won't happen until 4.0, which may yet be years away ? |
"It's not years away" according gsherwood.
Yes that's why I pointed it out. I thought you maybe wanted to close the issue since the phpcs will focus about php only for the next major. |
Not until the bug is either fixed or there is an RC for version 4.0. |
|
In another issue (talking about JS):
So I understand the same way that no CSS bug will be fixed in version 3. But you're still free to fix it :) |
|
@VincentLanglet You do realize I can read ? |
|
@jrfnl You do realize you’re aggressiv for no reason ? |
|
@VincentLanglet You do realize that is only in response to you aggressively trying to put pressure on me to close an issue while mansplaining the state of this repo to me ? |
You're the only one aggressive here.
This issue was opened for more than one year, with no activity at all. It is about a support which is deprecated and will be dropped. So no, I didn't put pressure, I suggested to close it. But since you can read:
I let you the choice, I'm not here to decide what should be closed or opened.
Oh, you're a woman ? Should I know it ? Does it change something ? I'm talking from an open-source developer to another open-source developer. I'm talking to an avatar with a pseudo. But you seems to juge people by their gender. That's sad. You were aggressive, now you are offensive |
|
So do your remarks and your aggressiveness. You could have kept this for you.
To Argue !== To put pressure.
You're the only one trying to put pressure.
Don't try to make me saying something I didn't.
I made a suggestion, and accepted the response in the third message.
I do respect the level of knowledge you have about this repository. I do appreciate every time the comment you make on pull request. Even if sometime giving more example would be nice since not every body, included me, has your level in PhpCs and in Php more generally. But I'm sorry because, all I see is an expert big-headed who mistreats a novice. Since the issue pre-date the announcement of the drop of CSS you may forgot this issue. |
|
Never you mind. You be you and good luck to you. |
Oh and you do realize that this is exactly the opposite of the behaviour you accuse me off ? I start from the presumption that people know what they are doing. If that's not the case, they can ask for more explanation, but if I'd give that explanation straight away, I'd be talking down to them. |
I've been closing JS tokenizer issues because I didn't want anyone to spend time working on them given I'm dropping support. I also don't think anyone should be using PHPCS for checking CSS or JS standards, so I'd encourage anyone using it for that purpose to migrate away as soon as practical. I'm happy to leave this open, but it's not something I'm going to devote time to. I would accept a PR to fix it, but I'd again encourage the use of a different tool if possible. |
This is a weird one and I have not been able to distill it down to a small code sample to easily reproduce the issue, however, with the complete test case file through which I came across the bug(s), I've been able to reproduce it consistently.
The problem is with the
comment_closernot always being set correctly in the token array of theT_DOC_COMMENT_OPEN_TAG.comment_closer. It is set at token 173, which is the comment closer for the next multi-line/* */comment.comment_closer. In this case, it is set at token 283, which is theT_CLOSE_TAGfor the document.Code for `testfile.css`
Short form debug output
-vvv output
The text was updated successfully, but these errors were encountered: