Allow single line closures

[CarsonF]

This code:

$func = function ($item) { return $item['foo']; };

Triggers:

• Generic.Formatting.DisallowMultipleStatements.SameLine
• PEAR.WhiteSpace.ScopeClosingBrace.Line
• Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore
• Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace

---

IMO the DisallowMultipleStatements error is a false positive. The code above is not the same as

$a = ''; $b = '';

---

For the rest of the errors, it would be nice to the have an option to allow single statement methods to be on one line (PHPStorm has this option). Maybe another option to further restrict it to only closures.

[tgr]

Referenced in https://phabricator.wikimedia.org/T154789

[claytonrcarter]

@gsherwood would you entertain a PR for this? If so, do you have any tips, suggestions or pointers for implementing support for single line closures? Would you prefer that each of the indicated Sniffs be updated to allow SLCs, or is there another tactic that I should look into? I might be biting off more than I can chew, but I would like to try working on this.

[gsherwood]

would you entertain a PR for this?

I can't see how this could be done with the existing sniffs. This is a specific rule for closures that does not exist in any of the included standards and is probably best served using a custom sniff. Including a rule like "Allow single line closures if they only have one statement" in these sniffs is far too specific.

[gsherwood]

Closing due to lack of additional interest in a new sniff.