Fixed bug #1746 : Very large reports can sometimes become garbled whe…

…n using the parallel option
squizlabs · Nov 8, 2017 · 53ba7e2 · 53ba7e2
1 parent 5ad186a
commit 53ba7e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.xml b/package.xml
@@ -77,6 +77,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
     -- Thanks to Nikola Kovacs for the patch
   - Fixed bug #1718 : Unclosed strings at EOF sometimes tokenized as T_WHITESPACE by the JS tokenizer
   - Fixed bug #1731 : Directory exclusions do not work as expected when a single file name is passed to phpcs
+  - Fixed bug #1746 : Very large reports can sometimes become garbled when using the parallel option
  </notes>
  <contents>
   <dir name="/">

diff --git a/src/Reporter.php b/src/Reporter.php
@@ -277,10 +277,9 @@ public function cacheFileReport(File $phpcsFile)
                     file_put_contents($this->tmpFiles[$type], '');
                 }
 
-                file_put_contents($this->tmpFiles[$type], $generatedReport, FILE_APPEND);
+                file_put_contents($this->tmpFiles[$type], $generatedReport, (FILE_APPEND | LOCK_EX));
             } else {
-                $flags = FILE_APPEND;
-                file_put_contents($report['output'], $generatedReport, FILE_APPEND);
+                file_put_contents($report['output'], $generatedReport, (FILE_APPEND | LOCK_EX));
             }//end if
         }//end foreach