Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: and with nested or generates incorrect logic #274

Closed
whacked opened this issue Dec 27, 2022 · 1 comment · Fixed by squint-cljs/compiler-common#18
Closed

Bug: and with nested or generates incorrect logic #274

whacked opened this issue Dec 27, 2022 · 1 comment · Fixed by squint-cljs/compiler-common#18

Comments

@whacked
Copy link

whacked commented Dec 27, 2022

I didn't dig into the root cause, but minimal repro:

(and (or true false) false)

generates JS:

true || false && false

which evaluates incorrectly to true; the correct output should be

(true || false) && false
@whacked whacked changed the title Bug: and with nested or generates incorrect logic Bug: and with nested or generates incorrect logic Dec 27, 2022
borkdude added a commit to squint-cljs/compiler-common that referenced this issue Dec 27, 2022
@borkdude
Fix logic precedence
28462a9 
Fixes squint-cljs/squint#274
@borkdude borkdude mentioned this issue Dec 27, 2022
Merged
borkdude added a commit to squint-cljs/compiler-common that referenced this issue Dec 27, 2022
@borkdude
Fix logic precedence
11c39ef 
Fixes squint-cljs/squint#274
wearethebork pushed a commit that referenced this issue Dec 27, 2022
@borkdude @github-actions
Fix logic precedence
de40e1a 
Fixes #274
borkdude added a commit that referenced this issue Dec 27, 2022
@borkdude
Fix logic precedence
678a59b 
Fixes #274
@borkdude
Copy link
Member

Should be fixed in 0.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logic precedence squint-cljs/compiler-common
2 participants
@whacked @borkdude