Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Commit

Permalink
Squint PR template (#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
borkdude authored Dec 25, 2022
1 parent d695493 commit 01fd1c8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/squint-filter-repo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
git fetch origin
bb bump-common --sha "$original_sha"
git add deps.edn
git commit -m "Bump compiler common"
GIT_EDITOR=true git commit --amend
git rebase origin/main --strategy-option theirs
echo "Pushing"
git push -u https://borkdude:[email protected]/squint-cljs/squint.git HEAD
Expand Down
14 changes: 3 additions & 11 deletions squint/.github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
Please answer the following questions and leave the below in as part of your PR.

- [ ] This PR corresponds to an [issue with a clear problem statement](https://github.com/babashka/babashka/blob/master/doc/dev.md#start-with-an-issue-before-writing-code): [#issue-number](https://github.com/clavascript/clavascript/issues/...) (mention the issue number in the previous link and remove this text)

- [ ] This PR provides tests for code additions and changes

- [ ] This PR does not contain bonus changes, i.e. changes not discussed in the linked issue. For those, please submit a new issue + PR.

After submitting this PR, please do not force-push your branch as this makes
collaboration easier. Push as many new commits to your branch, they will be
squashed upon merge.
Pull requests should be targeted at
[compiler-common](https://github.com/squint-cljs/compiler-common) and will be
merged here automatically after being accepted in compiler-common.
4 changes: 3 additions & 1 deletion squint/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1122,4 +1122,6 @@ export function neg_QMARK_(x) {

export function pos_QMARK_(x) {
return x > 0;
}
}

// comment

0 comments on commit 01fd1c8

Please sign in to comment.