-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation: Add es-mx dialect translation #728
Conversation
Can one of the admins verify this patch? |
OK to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File contents look okay now. You will need to update the errors/aliases file entry to prevent directory and symlink collision on binary install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now under 10-day criteria. Will do the integration parts myself as a followup PR shortly.
es-mx.po translation file
es-mx.po translation file
es-mx.po translation file
@yadij you mentioned "You will need to update the errors/aliases file entry to prevent directory and symlink collision on binary install." Do you know if this ever happened? We are getting failures when upgrading from 4.x to 5.x where it fails while renaming files in this directory. I finally tracked it down by running truss to determine that the files were being extracted to the old symlinked directory before the symlink directory gets replaced with a real folder, causing the following error during upgrade:
I was only able to work around this problem by deleting the symlink before trying pkg upgrade. Could this fix be added to an upcoming release? |
On second thought, I DO see es-mx in the errors/aliases file (commit), so it looks like that part was done, but perhaps there is still an issue when upgrading from a version where it used to be symlinked but now has its own locale? |
@moracca, ouch, the fix for this will have to be done by the package vendor - to ensure the old alias symlinks are updated/removed before the new package contents are installed. Our script does not do that in order to avoid removing admins custom symlinks. |
UPDATE: actually no that was wrong. The symlinks are created by our automake. I think I can/should fix it here. |
es-mx.po translation file