Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: split WorkflowConcurrency versioning to address source-breaking change #169

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[chore]: split WorkflowConcurrency versioning to address source-breaking change #169

merged 1 commit into from
Dec 14, 2022

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Dec 14, 2022 •
edited
Loading

Issue

  • Changed WorkflowConcurrency Worker implementation #164 removed a public API in the WorkflowConcurrency library, so it needs special-casing to conform to semantic versioning standards
  • once we bump Workflow to 2.x, we should be able to revert to a shared version for all the utility libraries

Description

  • add WORKFLOW_CONCURRENCY_VERSION support, and bump to 2.0.0
  • update supporting files where needed

@jamieQ jamieQ marked this pull request as ready for review December 14, 2022 20:28
@jamieQ jamieQ requested a review from a team as a code owner December 14, 2022 20:28
mjohnson12
mjohnson12 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@mjohnson12 mjohnson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should the workflow minor release change though because of the additions to the API that Westin added?

@jamieQ
Copy link
Contributor Author

jamieQ commented Dec 14, 2022

Looks good. Should the workflow minor release change though because of the additions to the API that Westin added?

yep! i will do that in a separate PR before making the new release

@jamieQ jamieQ merged commit 715e1ef into main Dec 14, 2022
@jamieQ jamieQ deleted the jquadri/release-prep-concurrency branch December 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjohnson12 mjohnson12 mjohnson12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamieQ @mjohnson12