Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: clarify some testing behaviors #161

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[chore]: clarify some testing behaviors #161

merged 1 commit into from
Oct 13, 2022

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Oct 13, 2022 •
edited
Loading

Issue

  • some behaviors in the testing facilities aren't particularly clear and may be confusing

Description

  • add clarification in comments that only a single output should be expected during a render test, and remove example code in comments suggesting this is possible.
  • add a new SignalProducerWorkflow testing method for use when no output is expected
  • add recovery suggestion to the diagnostic message produced when an unexpected child workflow is rendered in a test

@jamieQ jamieQ marked this pull request as ready for review October 13, 2022 18:44
@jamieQ jamieQ merged commit 37f52d7 into main Oct 13, 2022
@jamieQ jamieQ deleted the jquadri/chore-clarify-some-testing-behaviors branch October 13, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleve kyleve kyleve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamieQ @kyleve